GUIUtil::brintToFront workaround for Wayland #831
Conversation
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. ConflictsNo conflicts as of last run. |
|
🚧 At least one of the CI tasks failed. HintsMake sure to run all tests locally, according to the documentation. The failure may happen due to a number of reasons, for example:
Leave a comment here, if you need help tracking down a confusing failure. |
pablomartin4btc
force-pushed
the
gui-bringToFront-wayland-workaround
branch
from
f27d285 to
bcc6874
Compare
|
Concept ACK. |
pablomartin4btc
force-pushed
the
gui-bringToFront-wayland-workaround
branch
2 times, most recently
from
e4dfc7e to
19f8842
Compare
pablomartin4btc
force-pushed
the
gui-bringToFront-wayland-workaround
branch
from
19f8842 to
15aa7d0
Compare
3 participants
There are known issues around handling windows focus in
Wayland(this one specific in KDE but also in gnome).The idea is that the workaround will be executed if
bitcoin-qtis running usingWaylandplatform (e.g.:QT_QPA_PLATFORM=wayland ./src/qt/bitcoin-qt -regtest), since the workaround behaviour looks like re-opening the window again (which I tried to fix by moving the window to the original position and/ or re-setting the original geometry without success) while inX11(not sure in Mac) the currentGUIUtil::brintToFrontactually sets the focus to the desired window, keeping its original position as expected, and I didn't want to change that (X11behaviour).The solution was initially discussed with hebasto in #817.